Thanks to visit codestin.com
Credit goes to github.com

Skip to content

update MAINTAINERS, mirror guidelines into dev doc#1394

Merged
srenatus merged 2 commits into
dexidp:masterfrom
srenatus:sr/docs/maintainers
Jan 31, 2019
Merged

update MAINTAINERS, mirror guidelines into dev doc#1394
srenatus merged 2 commits into
dexidp:masterfrom
srenatus:sr/docs/maintainers

Conversation

@srenatus
Copy link
Copy Markdown
Contributor

Follow-up to both #1391 and #1281.

@srenatus srenatus self-assigned this Jan 29, 2019
@JoelSpeed
Copy link
Copy Markdown
Contributor

Looks pretty good. One thing that might be worth adding is some note on having new maintainers shadow reviewed for some period? As in if I start reviewing PRs then an existing maintainer would also have to approve the first 10 PRs I approve to build confidence in the new maintainers review abilities?

@srenatus
Copy link
Copy Markdown
Contributor Author

Hmm interesting idea. I guess we could do that, but I do wonder how formal we need to about this. After all, you can assign further reviewers -- if you're unsure about something, just leave your review and request one more from another maintainer. What do you think? 😃

@JoelSpeed
Copy link
Copy Markdown
Contributor

Yeah you're probably right, we don't need to be too formal. I guess I was just thinking as a new maintainer I would want a second opinion on the first few anyway so would do that myself, others are probably the same 😅

@srenatus srenatus merged commit b5826e6 into dexidp:master Jan 31, 2019
mmrath pushed a commit to mmrath/dex that referenced this pull request Sep 2, 2019
update MAINTAINERS, mirror guidelines into dev doc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants