update MAINTAINERS, mirror guidelines into dev doc#1394
Conversation
Signed-off-by: Stephan Renatus <[email protected]>
Signed-off-by: Stephan Renatus <[email protected]>
|
Looks pretty good. One thing that might be worth adding is some note on having new maintainers shadow reviewed for some period? As in if I start reviewing PRs then an existing maintainer would also have to approve the first 10 PRs I approve to build confidence in the new maintainers review abilities? |
|
Hmm interesting idea. I guess we could do that, but I do wonder how formal we need to about this. After all, you can assign further reviewers -- if you're unsure about something, just leave your review and request one more from another maintainer. What do you think? 😃 |
|
Yeah you're probably right, we don't need to be too formal. I guess I was just thinking as a new maintainer I would want a second opinion on the first few anyway so would do that myself, others are probably the same 😅 |
update MAINTAINERS, mirror guidelines into dev doc
Follow-up to both #1391 and #1281.