Use github login as the id#1396
Conversation
For downstream apps using a github handle is much simpler than working with numbers. WHilst the number is stable and the handle is not - GitHUb does give you a big scary wanring if you try and change it that bad things may happen to you, and generally few users ever change it. This can be enabled with a configuration option `useLoginAsId`
srenatus
left a comment
There was a problem hiding this comment.
LGTM -- thank you! 🎉 Just some nitpicks to get this through CI.
One question for clarification: there's no way to not have a login, right?
never say never - but I do not see how you can authenticate against github without an account which requires a login. |
srenatus
left a comment
There was a problem hiding this comment.
Thanks again. This looks good to me. 🎉
Would you mind squashing those commits? 😃
Yes I would mind; I consider it bad form (for some reasons see why here) However it is not my repo and if you are saying this will not be merged until I squash it then I will squash it (but this does not seem o be a rule looking at the history) |
|
We don't have any established, agreed-upon, strict rules; I guess it's a matter of taste mostly. (And a matter for forgetting about cleaning up the history most of the time -- at least when it comes to PRs I approve 😅) So, fine. I'll just merge this. Thanks again 🎉 |
|
Thank you @srenatus |
Use github login as the id
Allow an option to use the github user handle rather than an id.
For downstream apps using a github handle is much simpler than working with numbers.
Whilst the number is stable and the handle is not - GitHub does give you a big scary warning if you try and change it that bad things may happen to you, and generally few users ever change it.
This can be enabled with a configuration option
useLoginAsId