Round out logging interface with functions for all levels#1432
Merged
Conversation
ericchiang
approved these changes
May 12, 2019
Contributor
ericchiang
left a comment
There was a problem hiding this comment.
yeah, this seems fine.
mmrath
pushed a commit
to mmrath/dex
that referenced
this pull request
Sep 2, 2019
Round out logging interface with functions for all levels
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The logging interface added in #1408 captured only logging methods used in dex itself. I understand the rationale, but I also find it awkward to see functions like
Warnfleft out whenWarnexists. And similarly, havingErrorfbut notError.For projects that extend Dex to introduce additional connectors, for example, it feels awkward to have to use
fmt.SprintfforWarn, but not forError.