Add option in oidc to hit the optional userinfo endpoint#1433
Merged
Conversation
Contributor
Author
|
cc @ericchiang (as you seem to be the one working with PRs :) ) |
Contributor
|
Why is okta not returning username, email or email verified in their id token? |
Contributor
Author
|
I'm not sure I follow the question? This PR (and the linked docs) talk about some claims missing due to "think tokens". I have provided both a link to their documentation which explains it and code which supports this functionality. As to why this provider decided to do thin tokens I cannot say, but from what I understand this is allowed by spec -- so it seems reasonable to me that dex should optionally support it. |
ericchiang
reviewed
May 23, 2019
Contributor
ericchiang
left a comment
There was a problem hiding this comment.
Couple comments. Please squash your commits when updating
Some oauth providers return "thin tokens" which won't include all of the claims requested. This simply adds an option which will make the oidc connector use the userinfo endpoint to fetch all the claims.
Contributor
Author
|
@ericchiang Updated to address comments. |
mmrath
pushed a commit
to mmrath/dex
that referenced
this pull request
Sep 2, 2019
Add option in oidc to hit the optional userinfo endpoint
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some oauth providers return "thin tokens" which won't include all of the
claims requested. This simply adds an option which will make the oidc
connector use the userinfo endpoint to fetch all the claims.
as an example of an IDP that does this: https://support.okta.com/help/s/article/Okta-Groups-or-Attribute-Missing-from-Id-Token