microsoft: option for group UUIDs instead of name and group whitelist#1446
Conversation
|
Can we make this an enum instead of a boolean? Something like: Also are these actually UUIDs? (https://en.wikipedia.org/wiki/Universally_unique_identifier) That's a pretty specific format and I only see "id" referenced in the API 😃 |
|
@ericchiang Yes I can change it for an enum. About the "uuids", I took it from the Microsoft Graph documentation for the directoryObject resource type :
But I will change it for "id" instead. |
ericchiang
left a comment
There was a problem hiding this comment.
please squash your commits 😃
552cbd8 to
78088c6
Compare
|
Could you rebase this once more, please? I had merged a change refactoring the group filtering into a helper method that affected this PR, sorry. 😃 |
78088c6 to
754c38a
Compare
|
Hi @srenatus, rebase done. |
srenatus
left a comment
There was a problem hiding this comment.
Thank you 🎉 That's a nice contribution.
Just one nitpick. I'm afraid this connector has no tests, but it's OK if you don't want to be the person reducing that tech debt. If, however, you'd like to add some, that would be very welcome 😉
d684c93 to
4585850
Compare
|
@srenatus |
…list microsoft: option for group UUIDs instead of name and group whitelist
This PR add a
useGroupUUIDoption to return groups UUIDs instead of names. And, it change the behavior of thegroupsoption to not only allow user member of a particular group but also act as a whitelist for the groups return in the claim.The main reason for using group UUIDs, is that group names are not unique in Microsoft Azure AD.