Codestin Search App

alindeman · 2019-06-20T17:27:51Z

This PR takes the great work in #1454, reworks it a bit to lean on oidc.Verifier for verification, and adds tests.

Fixes #376
Closes #1133
Closes #1201
Closes #1453
Closes #1454

Co-authored-by: Yuxing Li <[email protected]> Co-authored-by: Francisco Santiago <[email protected]>

alindeman · 2019-06-20T17:38:19Z

/cc @srenatus @mdbraber @lstoll for review

srenatus · 2019-06-21T17:34:08Z

I'll review this next week. Thanks for contributing! 😃 🎉

srenatus

🎉 It's nice to see this come together, thanks for contributing. Some nitpicks/questions inside 😃

srenatus · 2019-06-24T08:36:14Z

+	}
+	rawIDToken := auth[len(prefix):]
+
+	verifier := oidc.NewVerifier(s.issuerURL.String(), &storageKeySet{s.storage}, &oidc.Config{SkipClientIDCheck: true})


Is this a costly operation? (I.e., do we want to store and re-use oidc.NewVerifier? (I have no idea, genuine question.)

It's not, as far as I can tell. The implementation is currently:

func NewVerifier(issuerURL string, keySet KeySet, config *Config) *IDTokenVerifier { return &IDTokenVerifier{keySet: keySet, config: config, issuer: issuerURL} }

Somewhat notably, constructing an oidc.Provider is a relatively expensive operation, but we don't have a need to do that in non-test code.

srenatus · 2019-06-24T08:42:29Z

+		{
+			name: "fetch userinfo",
+			handleToken: func(ctx context.Context, p *oidc.Provider, config *oauth2.Config, token *oauth2.Token) error {
+				_, err := p.UserInfo(ctx, config.TokenSource(ctx, token))


❓ Would it be worthwhile to assert something on the response?

I went back and forth on it. Not many of the other tests do, but since it ended up being easy enough, I've added something in 840065f. Let me know what you think.

We have a story around user info now

alindeman · 2019-06-24T14:10:04Z

🎉 It's nice to see this come together, thanks for contributing. Some nitpicks/questions inside 😃

@srenatus Thanks for the review. Let me know if you'd like to see anything else addressed.

srenatus

😃 LGTM, one question plus another nitpick. @JoelSpeed @ericchiang What do you think?

srenatus · 2019-06-25T14:20:22Z

 	github.com/cockroachdb/cmux v0.0.0-20170110192607-30d10be49292 // indirect
 	github.com/coreos/etcd v3.2.9+incompatible
-	github.com/coreos/go-oidc v0.0.0-20170307191026-be73733bb8cc
+	github.com/coreos/go-oidc v2.0.0+incompatible


❓Is this a problem somehow?

No, it mostly means this repository uses a v2 tag, but not in the native go mod way. In fact, it's not been converted to a go module yet at all (therefore incompatible).

I'm personally not concerned about it: it's pretty standard fare while the Go community converts things slowly to modules over time. If/when go-oidc becomes a module, we might have to update some imports, but otherwise shouldn't be a big deal.

srenatus · 2019-06-25T14:26:53Z

 	Auth          string   `json:"authorization_endpoint"`
 	Token         string   `json:"token_endpoint"`
 	Keys          string   `json:"jwks_uri"`
+	UserInfo      string   `json:"userinfo_endpoint"`


Could you expand this test case for the discovery json, please?

dex/server/server_test.go

Line 150 in 8959dc4

}

Good call. Done, 59b6595

alindeman · 2019-07-01T13:32:46Z

Any reviewers have any additional feedback or requests to change things?

JoelSpeed

I've had a read through and this seems sensible, happy with it if @srenatus is happy all his comments are resolved?

srenatus · 2019-07-01T20:19:49Z

If no one beats me to it, I'll merge this tomorrow and push a release tag

Co-authored-by: Andy Lindeman <[email protected]>

srenatus · 2019-07-02T07:25:35Z

I've considered another round-trip with the @alindeman for squashing commits, but... I don't think it matters that much. I'm going to push the big green button. 🚀

mdbraber · 2019-07-02T08:12:04Z

@srenatus @alindeman @jackielii @JoelSpeed thanks for all the work getting this implemented!

Add UserInfo endpoint

Replace wrong PR dexidp/dex#766 (implicit/hybrid flow) with the actual fix dexidp/dex#1473 (Add UserInfo endpoint). Update resolution text to describe the UserInfo endpoint feature. Signed-off-by: Andrew Anderson <[email protected]>

* 🌱 Add dex: UserInfo endpoint mission * 🌱 Add dex: UserInfo endpoint mission Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * Fix dex #376 mission: correct PR to #1473 (UserInfo endpoint) Replace wrong PR dexidp/dex#766 (implicit/hybrid flow) with the actual fix dexidp/dex#1473 (Add UserInfo endpoint). Update resolution text to describe the UserInfo endpoint feature. Signed-off-by: Andrew Anderson <[email protected]> --------- Signed-off-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Signed-off-by: Andrew Anderson <[email protected]> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

mdbraber and others added 5 commits June 5, 2019 22:11

Add userinfo endpoint

a8d059a

Co-authored-by: Yuxing Li <[email protected]> Co-authored-by: Francisco Santiago <[email protected]>

Fix changes

d7750b1

Formatting

74f4e74

Fix comments

3dd1bac

Bump go-oidc to latest v2

157c359

alindeman force-pushed the add-user-endpoint branch from 7592623 to 7970903 Compare June 20, 2019 17:30

srenatus reviewed Jun 22, 2019

View reviewed changes

Comment thread server/handlers.go Outdated

Use oidc.Verifier to verify tokens

46f5726

alindeman force-pushed the add-user-endpoint branch from 7970903 to 46f5726 Compare June 22, 2019 17:18

srenatus reviewed Jun 24, 2019

View reviewed changes

alindeman added 3 commits June 24, 2019 09:39

Assert something about the returned userinfo

840065f

Remove comment

21174c0

We have a story around user info now

ctx is not used

8959dc4

srenatus approved these changes Jun 25, 2019

View reviewed changes

userinfo_endpoint is required

59b6595

joshua-rutherford suggested changes Jun 27, 2019

View reviewed changes

Comment thread server/handlers.go

Fixed shadowed variable declaration

5b66bf0

JoelSpeed approved these changes Jul 1, 2019

View reviewed changes

lstoll pushed a commit to pardot/deci that referenced this pull request Jul 1, 2019

Add userinfo endpoint from dexidp/dex#1473

e5a14c2

lstoll pushed a commit to pardot/deci that referenced this pull request Jul 1, 2019

Add userinfo endpoint from dexidp/dex#1473

fafa913

Co-authored-by: Andy Lindeman <[email protected]>

lstoll mentioned this pull request Jul 1, 2019

Add userinfo endpoint pardot/deci#3

Merged

lstoll pushed a commit to pardot/deci that referenced this pull request Jul 1, 2019

Add userinfo endpoint from dexidp/dex#1473 (#3)

36a0fe2

Co-authored-by: Andy Lindeman <[email protected]>

srenatus merged commit 8b4dbb9 into dexidp:master Jul 2, 2019

mmrath pushed a commit to mmrath/dex that referenced this pull request Sep 2, 2019

Merge pull request dexidp#1473 from alindeman/add-user-endpoint

ed19685

Add UserInfo endpoint

aoldershaw mentioned this pull request Jul 15, 2020

Make access tokens smaller #1763

Open

satterly mentioned this pull request Jul 2, 2021

Enable customization of openid "scope" attribute alerta/alerta-webui#477

Closed

nabokihms mentioned this pull request Feb 17, 2023

OIDC groups and userinfo support #1463

Closed

Conversation

alindeman commented Jun 20, 2019

Uh oh!

alindeman commented Jun 20, 2019

Uh oh!

srenatus commented Jun 21, 2019

Uh oh!

Uh oh!

srenatus left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alindeman commented Jun 24, 2019

Uh oh!

srenatus left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

alindeman commented Jul 1, 2019

Uh oh!

JoelSpeed left a comment

Choose a reason for hiding this comment

Uh oh!

srenatus commented Jul 1, 2019

Uh oh!

srenatus commented Jul 2, 2019

Uh oh!

mdbraber commented Jul 2, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants