Return HTTP 400 for invalid state parameter#1490
Merged
Merged
Conversation
srenatus
approved these changes
Jul 22, 2019
Contributor
srenatus
left a comment
There was a problem hiding this comment.
Thank you! This seems correct to me.
I wonder if there's value in adding a test case. What do you think? (Not meant as a suggestive question.)
Contributor
Author
|
I think there's value in testing some of that handler's error conditions, will submit a separate pull request for it before the weekend. |
Contributor
|
@momokatte would you mind rebasing the branch? It's got some merge commit in it right now that I'd rather not get into master 😃 |
Contributor
Author
|
Done, and sorry about the mess -- I have a better handle on this workflow now and will avoid making changes in my own master branch. |
bonifaido
approved these changes
Aug 2, 2019
mmrath
pushed a commit
to mmrath/dex
that referenced
this pull request
Sep 2, 2019
Return HTTP 400 for invalid state parameter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The state parameter is invalid, expired, or already consumed and this HTTP request should not be retried.