connector/gitlab: implement useLoginAsID as in GitHub connector#1497
Merged
Conversation
srenatus
approved these changes
Jul 27, 2019
Contributor
srenatus
left a comment
There was a problem hiding this comment.
LGTM. Funny situation with that test 😉 thanks for fixing it!
c71f52f to
ff34e57
Compare
Contributor
|
Thank you! 🎉 |
mmrath
pushed a commit
to mmrath/dex
that referenced
this pull request
Sep 2, 2019
connector/gitlab: implement useLoginAsID as in GitHub connector
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not user if we can use the same name
useLoginAsIDas in GitHub since in GitLab it is called Username in the API (vs Login). But in this case, the config is the same.We have a test for it as well (which I have added, but now it is valid :)