Allow arbitrary data to be passed to templates#1504
Merged
Conversation
srenatus
reviewed
Aug 3, 2019
Contributor
srenatus
left a comment
There was a problem hiding this comment.
Thank you! 🎉 😃 Docs on templates are great!
I'd love to see some Web/frontend stuff added to tests.
Contributor
|
Also let's please squash these before merging. :) |
Contributor
Author
|
Tests added and docs updated! Will you squash merge on GitHub, or you want me to squash first? |
Contributor
|
Thanks, can you please do the squashing? :)
…On Tue, 6 Aug 2019, 19:12 Marc-André Dufresne, ***@***.***> wrote:
Tests added and docs updated! Will you squash merge on GitHub, or you want
me to squash first?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1504?email_source=notifications&email_token=AAGUR3XAQR63VZFEMRWV4JLQDGWG3A5CNFSM4II55ATKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOD3V2T2Q#issuecomment-518760938>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AAGUR3TMPWNPEVE7JHAXPD3QDGWG3ANCNFSM4II55ATA>
.
|
215d54c to
d458e88
Compare
mmrath
pushed a commit
to mmrath/dex
that referenced
this pull request
Sep 2, 2019
Allow arbitrary data to be passed to templates
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This follows a discussion from #1470