Add tests for some callback handler error conditions#1510
Merged
Conversation
srenatus
reviewed
Aug 3, 2019
Contributor
srenatus
left a comment
There was a problem hiding this comment.
Thanks for adding these! 👏 Some comments inline 👇
09dfa2b to
43d1a04
Compare
Contributor
Author
|
amended commit with the suggested changes |
srenatus
approved these changes
Aug 6, 2019
| for i, r := range tests { | ||
| server.ServeHTTP(rr, httptest.NewRequest("GET", r.TargetURI, nil)) | ||
| if rr.Code != r.ExpectedCode { | ||
| t.Fatalf("test %d expected %d, got %d", i, r.ExpectedCode, rr.Code) |
Contributor
There was a problem hiding this comment.
Ok, this is nitpicking, but we don't have to use Fatal here -- if one fails, the following ones could still be tested.
Also, if you use t.Run("test name or number", func (t *testing) { /* test body */ }), you can use t.Fatal inside the subtest without failing the entire test.
At any rate this is better than what we have right now, so let's get this merged, and extend on it as needed. 😃
mmrath
pushed a commit
to mmrath/dex
that referenced
this pull request
Sep 2, 2019
Add tests for some callback handler error conditions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exercises some validation logic in the callback handler