Add reflection to grpc api#1512
Conversation
|
travis wasn't able to connect to github during the test - unsure how to get travis to try again |
srenatus
left a comment
There was a problem hiding this comment.
LGTM, thanks for this! 😃 Would you mind squashing this into two commits -- one for the code, one for the revendor? That would also trigger travis again, I hope 🤞
There was a problem hiding this comment.
Please put that into a section with the other 3rd-party imports :)
There was a problem hiding this comment.
Sorry, I IDE did that automatically for me and I wasn't paying attention - sure
Sure, but just know I was only following dex's guidelines That being said do you want, in the future, for commits involving dependencies to be in the same commit as regular code changes? |
|
@venezia thanks for pointing out those guidelines. I had forgotten about that. They're quite agreeable -- at any rate, could you amend your commits to satisfy them? 😉
and the third commit can be squashed into the first one? |
|
If you want to split commits more (while adhering to the guidelines), please do so -- I'm sorry for misleading you here 😉 |
no, this is what happens when I misread a comment while still waking up. I think here one commit is just fine, sometimes if it is bigger maybe more than one commit is better (if they're doing separate things, etc.) but that's for another day. But specifically, the small correction to the documentation regarding plaintext mode - its part of this "add reflection to grpc api" commit, but it really has nothing to do with adding reflection to grpc - it should be there regardless because it fixes something else that is incorrect. Regardless, things should be squashed and commented better now. |
Add reflection to gRPC API (configurable)
This will add reflection as an option for the grpc api.
It also makes a small correction in the documentation - dex will not create self signed certificates if certs are not provided, rather it runs in plaintext mode.
Does not fix, but this work was discussed in #1499