Clarify the origin of the ca file in the Kubernetes guide#1521
Merged
Conversation
srenatus
reviewed
Aug 28, 2019
Contributor
srenatus
left a comment
There was a problem hiding this comment.
Thank you for your contribution! 🎈 Just one small change to the URL and this is good to go! 🎉
Contributor
Author
|
Hey @srenatus thanks for your review. I addressed your feedback, WDYT 🙂 |
Contributor
|
@erwinvaneyk would you mind much to squash these two commits? 😃 |
Contributor
Author
|
@srenatus - Done! |
Contributor
|
Thank you! 😃 |
mmrath
pushed a commit
to mmrath/dex
that referenced
this pull request
Sep 2, 2019
Clarify the origin of the ca file in the Kubernetes guide
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Kubernetes guide has a bit of an unusual structure, where the config shown at the beginning of the document is not valid, and requires steps later in the document.
To clarify it a bit, and avoid restructuring the whole document, I propose to add a small note addressing the CA file used in the apiserver config.