MySQL storage backend#924
Conversation
It will be shared by both Postgres and MySQL configs. Signed-off-by: Pavel Borzenkov <[email protected]>
It will be used by MySQL test function as well. Signed-off-by: Pavel Borzenkov <[email protected]>
MySQL driver doesn't support this. Signed-off-by: Pavel Borzenkov <[email protected]>
There is no way to configure SSL yet. Signed-off-by: Pavel Borzenkov <[email protected]>
Signed-off-by: Pavel Borzenkov <[email protected]>
|
Hmm, looks like Tarvis is using MySQL 5.5 which doesn't support fractional DATETIME values. 5.6 is available in 'trusty' CI environment. I'll remove MySQL backend from CI until the switch is made. |
Signed-off-by: Pavel Borzenkov <[email protected]>
Signed-off-by: Pavel Borzenkov <[email protected]>
rithujohn191
left a comment
There was a problem hiding this comment.
Thank you for this PR. Overall looks good. But we will have to ensure that the Travis tests pass before integrating. We don't plan to switch over to 'trusty' any time soon so will it be possible for you to make do with MySQL 5.5 and eliminate the need for supporting fractional DATETIME values?
| ) | ||
|
|
||
| // NetworkDB contains options common to SQL databases accessed over network. | ||
| type NetworkDB struct { |
There was a problem hiding this comment.
Please add individual comments describing each attribute.
| Timeout: time.Second * time.Duration(s.ConnectionTimeout), | ||
|
|
||
| ParseTime: true, | ||
| Params: map[string]string{ |
There was a problem hiding this comment.
Please add a comment to explain this
|
@rithujohn191 The problem is that conformance tests require the storage to provide millisecond precision right now. I see several ways to fix this:
Personally, I think the third one is the way to go and it does not require a lot of coding. What do you think? |
|
Hi guys, what the PR status? |
|
Unfortunately, I didn't have time to finish it. I'll try to complete it in the coming days. I'll go with the item 2 from my proposal (relaxing timestamp precision requirements to full second). |
|
I don't think the dex team has the bandwidth to maintain another storage implementation. If someone wants to step up as a maintainer, we would consider merging, But without someone dedicated to this storage, I don't think this is going to happen today. |
|
Dex supports MySQL now. |
The pull request adds MySQL storage backend.