merge next into master #741
Draft
raymondk wants to merge 18 commits into
Draft
Conversation
--------- Co-authored-by: Linwei Shang <[email protected]> Co-authored-by: David Frank <[email protected]>
Looks like a recent bump of the Rust version on CI introduced new Clippy lints that make CI fail on #668 This PR fixes those lint errors on the `next` branch.
Gets rid of the dodgy `is_empty` function that performed full traversals of documents to tell if they were empty.
β¦deprecations (#665) **Overview** The JavaScript target would be more useful (especially to Azle developers) if it exported the IDL type objects that it generates. We also no longer need the factory functions as of `3.0.0`, thus we will mark them deprecated and provide direct exports for that previous functionality. **Requirements** The JavaScript target should export all of the IDL type objects, including the generated `IDL.Service` and `init args`, without the need to use a factory function. **Considerations** There are no breaking changes besides some formatting of the generated JavaScript files. The `idflFactory` and `init` functions have been marked as deprecated but not removed. Developers can choose to import the `IDL` type objects now, but they are not forced to. This is mainly an ergonomic change with deprecations to prepare for a future with the best developer experience by default.
**Overview** Named arguments can also be in the return type according to the spec. This PR updates the grammar to collect the names of the return types. As a consequence, it fixes a regression introduced in https://github.com/dfinity/candid/pull/612/files#diff-c5ff9610c5d6538ec79f3d465965d2b3a3e3b628b16854a91b4b4a90ba766a57L220-L230, in order to keep parsing the return types with arguments without errors. Updates a test case to check if the behavior has been restored.
Brings master's ~45 commits (releases up to candid 0.10.29 / candid_parser 0.3.2 / didc 0.6.1 / ic_principal 0.1.3, decode/encode perf work, the icp-cli/Vite UI rewrite, doc-comment preservation #707, collect-all subtype errors #725) onto the next branch while preserving next's breaking v-next features: ArgType return/arg name collection (#684), TypeKey named-type keys (#590, re-applied on next), the pretty-printing combinator (#668), and the JS/TS idlService/idlInitArgs exports (#665). Conflict resolution: - 16 .d.ts/.js/.mo/.rs goldenfiles regenerated from merged bindings (UPDATE_GOLDENFILES=1) β output now carries BOTH master's @icp-sdk/core imports AND next's idlService/idlInitArgs exports. - Cargo.lock / bench Cargo.lock regenerated; crate versions take master's. - 7 source files hand-merged: master's subtype-error rewrite (#725) re-threaded over next's ArgType signatures; doc-comment emission folded into next's pretty-printing combinator; doc-comment fields kept alongside TypeKey/ArgType types and the @icp-sdk TypeScript imports. - candid_parser/typing.rs (auto-merged but semantically broken): master's new validate_type recursion guard adapted to TypeKey-keyed env and ArgType args. Verified: cargo check/test pass under default, --no-default-features, and --features all; clippy clean. Co-Authored-By: Claude Opus 4.8 (1M context) <[email protected]>
Click to see raw report |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.