refactor: Use CompoundCycles in helpers in ExecutionTest#9696
Merged
Conversation
Contributor
michael-weigelt
approved these changes
Apr 1, 2026
Contributor
Author
|
@michael-weigelt Can you please add this to the queue? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR switches various helper functions in
ExecutionTestthat calculate fees to returnCompoundCyclesinstead ofCycles. This pushes the decision on what part of the computed fee (real or nominal) to implementors of the test which makes more sense depending on what needs to be tested. It also facilitates computing expected balance or metrics changes from the same compound value which strengthens the tests.