Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Reduce Buffer Size #542

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
PJEstrada merged 2 commits into from
Jan 27, 2022
Merged

Reduce Buffer Size #542

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ab0fe6
fix: reduce buffer size to 3 frames
PJEstrada Jan 27, 2022
de12ab3
feat: add image buffer as config
PJEstrada Jan 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions frontend/src/components/annotation/annotation_core.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -673,6 +673,7 @@
class="pb-0"
:current_video="current_video"
:video_mode="video_mode"
:max_num_image_buffer="label_settings.max_image_buffer"
:player_height="'80px'"
:parent_save="this.detect_is_ok_to_save"
:video_primary_id="'video_primary'"
Expand Down Expand Up @@ -1254,6 +1255,7 @@ export default Vue.extend({
filter_contrast: 100, // Percentage. A value of 0% will create a drawing that is completely black. A value of 100% leaves the drawing unchanged.
filter_grayscale: 0, // A value of 100% is completely gray-scale. A value of 0% leaves the drawing unchanged.
instance_buffer_size: 60,
max_image_buffer: 3,
canvas_scale_global_is_automatic: true,
canvas_scale_global_setting: 0.5,
left_nav_width: 450,
Expand Down
15 changes: 13 additions & 2 deletions frontend/src/components/annotation/toolbar.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -332,7 +332,7 @@
</div>

<div>
<task_status
<task_status
v-if="task && task.id && task.job"
:task_status="task.status"
:task_comment="task.task_comment"
Expand Down Expand Up @@ -865,7 +865,7 @@
limit on this (ie max 1000) , so need to update
there too if required-->
<v-slider
label="Video Instance Buffer"
label="Video Annotations Buffer"
min="15"
max="300"
thumb-label
Expand All @@ -874,6 +874,17 @@
>
</v-slider>

<v-slider
label="Video Frames Buffer"
min="3"
max="50"
thumb-label
ticks
v-model="label_settings_local.max_image_buffer"
>
</v-slider>


<tooltip_button
tooltip_message="Restore All User Settings & Prompts"
@click="$store.commit('restore_default_user_settings')"
Expand Down
13 changes: 7 additions & 6 deletions frontend/src/components/video/video.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -466,6 +466,9 @@ export default Vue.extend( {
},
'any_frame_saving':{
default: false
},
'max_num_image_buffer':{
default: 3
}
},
components: {
Expand All @@ -475,7 +478,6 @@ export default Vue.extend( {
return {

error: {},
MAX_NUM_URL_BUFFER: 15,
mouse_x: null,
mouse_y: null,
mouse_page_x: null,
Expand Down Expand Up @@ -554,9 +556,8 @@ export default Vue.extend( {
}
},
computed: {
MAX_NUM_IMAGE_BUFFER: function(){
// This is to ensure we always have the urls available for fetching.
return this.MAX_NUM_URL_BUFFER - 5;
MAX_NUM_URL_BUFFER: function(){
return this.$props.max_num_image_buffer + 5;
},
video_settings: function () {
if (this.current_video) {
Expand Down Expand Up @@ -1306,8 +1307,8 @@ export default Vue.extend( {
return result
},
fetch_next_images: async function(frame_number){
let next_frames = this.range(frame_number, frame_number + this.MAX_NUM_IMAGE_BUFFER, 1)
let prev_frames = this.range(frame_number, frame_number - this.MAX_NUM_IMAGE_BUFFER, 1);
let next_frames = this.range(frame_number, frame_number + this.max_num_image_buffer, 1)
let prev_frames = this.range(frame_number, frame_number - this.max_num_image_buffer, 1);
next_frames.filter(frame => frame <= this.current_video.frame_count)
prev_frames.filter(frame => frame >= 0)
let frames_to_fetch = []
Expand Down