Cancel Frames/Video requests on video drawable canvas on destroy#551
Merged
Cancel Frames/Video requests on video drawable canvas on destroy#551
Conversation
This was causing the requests from 15 videos to be queued, and when going to the video annotation this was consuming all the bandwith for the frames fetching
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
PJEstrada
added a commit
that referenced
this pull request
Nov 16, 2022
* fix: cancel requests on video drawable canvas on destroy This was causing the requests from 15 videos to be queued, and when going to the video annotation this was consuming all the bandwith for the frames fetching * cleanup Co-authored-by: Pablo <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context is that user goes to the task list before annotation core.
If we don't cancel the requests, then the frames/video files of 15 tasks will be fetching while they open the annotation core video.
This was causing the requests from 15 videos to be queued, and when going to the video annotation this was consuming all the bandwith for the frames fetching
** Also includes small bugfixes to report runner