Login new assumptions #820
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1) The part that was confusing was that change project was within the project menu. So it meant that various conditions that made sense for most of the menu did not make sense for change project. 2) Now there is a dedicated change project, that will only show up when there is no active project, the user's email is verified, and there is a project available 3) Now the project/task menu only shows when there's an active project. While there's some UI trade offs for now that seems simpler then the disabled 4) Note for reactivity and context it seems that we need it in the menu and button while we could "get smart" about some of the other resume onboarding, change, new project etc. there are so many contextual things for now feels better to keep that screen open - again keeping in mind it's a fallback that users should rarely get to
Old iteration direction
Member
Author
|
This is a pretty small one so am planning to merge once tests pass |
|
Test summary
Run details
View run in Cypress Dashboard ➡️ Failures
Flakiness
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
||||||||||||||||||||||||||||||||||
PJEstrada
pushed a commit
that referenced
this pull request
Nov 16, 2022
* Restore Not sure why this was commented out but it's causing a vue warn Maybe other functions we need to restrict here but then let's remove it entirely etc * Add dedicated change button 1) The part that was confusing was that change project was within the project menu. So it meant that various conditions that made sense for most of the menu did not make sense for change project. 2) Now there is a dedicated change project, that will only show up when there is no active project, the user's email is verified, and there is a project available 3) Now the project/task menu only shows when there's an active project. While there's some UI trade offs for now that seems simpler then the disabled 4) Note for reactivity and context it seems that we need it in the menu and button while we could "get smart" about some of the other resume onboarding, change, new project etc. there are so many contextual things for now feels better to keep that screen open - again keeping in mind it's a fallback that users should rarely get to * Remove old code `annotation_assignment` Old iteration direction * Add clear_userProjects_list concept * Remove old annotation_project concept
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add dedicated change project button for rare contexts
Keeping in mind the context that we normally set the project when the user logins in, in the rare event that there is no project:
The part that was confusing was that change project was within the project menu.
This meant that various conditions that made sense for most of the menu did not make sense for change project.
Now there is a dedicated change project, that will only show up when there is no active project, the user's email is verified, and there is a project available
Now the project and task menus only shows when there's an active project.
While there's some UI trade offs for now that seems simpler then the disabled
while we could "get smart" about some of the other resume onboarding, change, new project etc. there are so many contextual things for now feels better to keep that screen open - again keeping in mind it's a fallback that users should rarely get to
this iteration should close #817