DEV: Deprecate api.decoratePluginOutlet
#24145
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This API is not used by any known themes/plugins, and is problematic for a few reasons - It doesn't work on modern plugin connectors which have no wrapper element - Making modifications to Ember-rendered DOM elements can lead to catastrophic and surprising errors - It doesn't re-run when arguments to a plugin outlet change This commit adds the deprecation notice, and refactors the tests so that they do not rely on any real core plugin outlets
CvX
reviewed
Oct 29, 2023
app/assets/javascripts/discourse/tests/integration/components/plugin-outlet-decorator-test.gjs
Outdated
Show resolved
Hide resolved
app/assets/javascripts/discourse/tests/integration/components/plugin-outlet-decorator-test.gjs
Outdated
Show resolved
Hide resolved
app/assets/javascripts/discourse/tests/integration/components/plugin-outlet-decorator-test.gjs
Outdated
Show resolved
Hide resolved
app/assets/javascripts/discourse/tests/integration/components/plugin-outlet-decorator-test.gjs
Outdated
Show resolved
Hide resolved
app/assets/javascripts/discourse/tests/integration/components/plugin-outlet-decorator-test.gjs
Outdated
Show resolved
Hide resolved
Co-authored-by: Jarek Radosz <[email protected]>
davidtaylorhq
commented
Oct 30, 2023
CvX
approved these changes
Oct 30, 2023
qunit-dom uses getComputedStyle, which varies based on other CSS and potentially by browser. We want to test the value of the style attribute on the element.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This API is not used by any known themes/plugins, and is problematic for a few reasons
It doesn't work on modern plugin connectors which have no wrapper element
Making modifications to Ember-rendered DOM elements can lead to catastrophic and surprising errors
It doesn't re-run when arguments to a plugin outlet change
This commit adds the deprecation notice, and refactors the tests so that they do not rely on any real core plugin outlets