-
Notifications
You must be signed in to change notification settings - Fork 8.5k
DEV: Show login-required screen in root route #32350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are making this the only option for our login/signup pages on April 29th, 2025, per https://meta.discourse.org/t/introducing-our-new-fullscreen-signup-and-login-pages/340401. This commit removes the `full_page_login` setting and any logic around it, as well as deleting the old login and signup modals, and removing leftover problem checks and settings from the database.
683cc5b
to
b15b22b
Compare
ZogStriP
approved these changes
Apr 30, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tried it locally and works great 👍
LGTM
Thanks for testing locally @ZogStriP! |
pmusaraj
added a commit
that referenced
this pull request
May 2, 2025
This was referenced May 4, 2025
pmusaraj
added a commit
that referenced
this pull request
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes means that login-required sites will show a splash screen on
/
. Users heading to/login
or/signup
will see the respective forms.This depends on #32189