Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DEV: Show login-required screen in root route #32350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 30, 2025

Conversation

pmusaraj
Copy link
Contributor

@pmusaraj pmusaraj commented Apr 17, 2025

This changes means that login-required sites will show a splash screen on /. Users heading to /login or /signup will see the respective forms.

This depends on #32189

@github-actions github-actions bot added the i18n PRs which update English locale files or i18n related code label Apr 17, 2025
@pmusaraj pmusaraj changed the base branch from main to dev/remove-full-page-login-feature April 17, 2025 14:41
@pmusaraj pmusaraj changed the title Separaet login required route rebased DEV: Show login-required screen in root route Apr 17, 2025
@github-actions github-actions bot removed the i18n PRs which update English locale files or i18n related code label Apr 17, 2025
Base automatically changed from dev/remove-full-page-login-feature to main April 29, 2025 08:40
martin-brennan and others added 5 commits April 29, 2025 10:35
We are making this the only option for our login/signup
pages on April 29th, 2025, per
https://meta.discourse.org/t/introducing-our-new-fullscreen-signup-and-login-pages/340401.

This commit removes the `full_page_login` setting and any logic
around it, as well as deleting the old login and signup modals,
and removing leftover problem checks and settings from the database.
@pmusaraj pmusaraj force-pushed the separaet-login-required-route-rebased branch from 683cc5b to b15b22b Compare April 29, 2025 14:37
@pmusaraj pmusaraj marked this pull request as ready for review April 29, 2025 15:20
Copy link
Member

@ZogStriP ZogStriP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tried it locally and works great 👍

LGTM

@pmusaraj
Copy link
Contributor Author

Thanks for testing locally @ZogStriP!

@pmusaraj pmusaraj merged commit 10df7fd into main Apr 30, 2025
16 checks passed
@pmusaraj pmusaraj deleted the separaet-login-required-route-rebased branch April 30, 2025 16:32
pmusaraj added a commit that referenced this pull request May 2, 2025
pmusaraj added a commit that referenced this pull request May 2, 2025
pmusaraj added a commit that referenced this pull request May 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants