Thanks to visit codestin.com
Credit goes to github.com

Skip to content

FEAT: type hint#417

Open
iwakitakuma33 wants to merge 6 commits into
django:mainfrom
iwakitakuma33:feat/type_hint
Open

FEAT: type hint#417
iwakitakuma33 wants to merge 6 commits into
django:mainfrom
iwakitakuma33:feat/type_hint

Conversation

@iwakitakuma33

@iwakitakuma33 iwakitakuma33 commented May 29, 2025 •
edited
Loading

Copy link
Copy Markdown

@iwakitakuma33 iwakitakuma33 mentioned this pull request May 29, 2025
Open
@iwakitakuma33

iwakitakuma33 commented May 29, 2025 •
edited
Loading

Copy link
Copy Markdown
Author

@amirreza8002
thanks for your review. I will do without redis-py!

best

iwakitakuma33
iwakitakuma33 commented May 29, 2025
View reviewed changes
Comment thread channels_redis/core.py Outdated
Comment on lines +25 to +26
from redis.asyncio.connection import ConnectionPool
from redis.asyncio.client import Redis

@iwakitakuma33 iwakitakuma33 May 29, 2025 •
edited
Loading

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amirreza8002
Shouldn't I also use Redis and ConnectionPool?

@bigfootjon

bigfootjon commented Jun 8, 2025

Copy link
Copy Markdown
Collaborator

Sorry for the slow reply, 2 major pieces of feedback:

  1. We need some kind of CI on these changes. Something like how asgiref does it: https://github.com/django/asgiref/blob/main/tox.ini#L11
  2. This PR should ONLY add type-hints, please revert all other changes like the xfail removals

@iwakitakuma33

iwakitakuma33 commented Jul 4, 2025

Copy link
Copy Markdown
Author

Sorry for the slow reply, 2 major pieces of feedback:

  1. We need some kind of CI on these changes. Something like how asgiref does it: https://github.com/django/asgiref/blob/main/tox.ini#L11
  2. This PR should ONLY add type-hints, please revert all other changes like the xfail removals

@amirreza8002 @bigfootjon
Thanks for replying.

The xfail fix has been reverted.
The import order has been corrected.
mypy ci has been introduced.
Any has been used where necessary to reduce the number of error messages in mypy results.

@iwakitakuma33 iwakitakuma33 force-pushed the feat/type_hint branch 2 times, most recently from 198754e to 449493c Compare July 7, 2025 17:19
@iwakitakuma33

iwakitakuma33 commented Jul 15, 2025

Copy link
Copy Markdown
Author

@amirreza8002 @bigfootjon
I fixed fail of CI.

Could you approve workflow awaiting?

@iwakitakuma33

iwakitakuma33 commented Jul 26, 2025

Copy link
Copy Markdown
Author

@carltongibson
thanks for approve workflow.

All tests were successful, but only the package dependency resolution error failed.
I have resolved the conflict with the main branch. Can you approve the side workflow?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@iwakitakuma33 @bigfootjon