Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Removed unnecessary left/right in admin sidebar CSS. #14204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 31, 2021
Merged

Removed unnecessary left/right in admin sidebar CSS. #14204

merged 1 commit into from
Mar 31, 2021

Conversation

felixxm
Copy link
Member

@felixxm felixxm commented Mar 31, 2021 •
edited
Loading

left/right are unnecessary are unnecessary and create a visual gap.

After Before
image image
image image

This is a tiny tweak 😄
image

@felixxm
Copy link
Member Author

felixxm commented Mar 31, 2021

@knyghty Do you want to take a look?

knyghty
knyghty approved these changes Mar 31, 2021
View reviewed changes
Copy link
Member

@knyghty knyghty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Not sure why it was there originally.

@felixxm felixxm requested a review from carltongibson March 31, 2021 09:43
@felixxm
Copy link
Member Author

felixxm commented Mar 31, 2021

@knyghty Thanks for checking 👍

carltongibson
carltongibson approved these changes Mar 31, 2021
View reviewed changes
Copy link
Member

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, yep. Nice. Less is more here :)

@felixxm felixxm merged commit 548dce5 into django:main Mar 31, 2021
@felixxm felixxm deleted the sidebar-css-tweaks branch March 31, 2021 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carltongibson carltongibson carltongibson approved these changes

+1 more reviewer

@knyghty knyghty knyghty approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@felixxm @carltongibson @knyghty