Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

felixxm
Copy link
Member

@felixxm felixxm commented Sep 11, 2023

No description provided.

@felixxm felixxm force-pushed the django51 branch 2 times, most recently from dd72ac5 to 0d36f04 Compare September 12, 2023 07:11
@felixxm felixxm force-pushed the django51 branch 6 times, most recently from 15f4083 to 6f26da7 Compare September 15, 2023 07:38
@felixxm felixxm added the selenium Apply to have Selenium tests run on a PR label Sep 15, 2023
@felixxm felixxm changed the title [WIP] Bootstrapped Django 5.1. Bootstrapped Django 5.1. Sep 15, 2023
@felixxm felixxm marked this pull request as ready for review September 15, 2023 08:55
@felixxm felixxm force-pushed the django51 branch 2 times, most recently from c0f6b98 to 433d1fd Compare September 18, 2023 13:10
@felixxm felixxm requested a review from a team September 18, 2023 13:13
@nessita
Copy link
Contributor

nessita commented Sep 18, 2023

It seems that there are some versionadded that may need removing?

docs/topics/auth/customizing.txt:734:        .. versionadded:: 4.1.8
docs/ref/settings.txt:1070:.. versionadded:: 3.2.18

Copy link
Member

@carltongibson carltongibson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(Bar @nessita's query) I think this looks good. 👍 Thanks!

@felixxm
Copy link
Member Author

felixxm commented Sep 18, 2023

It seems that there are some versionadded that may need removing?

docs/topics/auth/customizing.txt:734:        .. versionadded:: 4.1.8
docs/ref/settings.txt:1070:.. versionadded:: 3.2.18

I removed remaining versionadded annotations.

@felixxm
Copy link
Member Author

felixxm commented Sep 18, 2023

Thanks for reviews 👍

@felixxm felixxm merged commit 0e560ed into django:main Sep 18, 2023
@felixxm felixxm deleted the django51 branch September 18, 2023 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
selenium Apply to have Selenium tests run on a PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants