Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[WIP] Fixed #20581 -- Added class based index Unique and UniqueDeferred. #8620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[WIP] Fixed #20581 -- Added class based index Unique and UniqueDeferred. #8620

wants to merge 1 commit into from

Conversation

jdufresne
Copy link
Member

UniqueDeferred can be used to create a deferred unique constraint. For class based unique constraints to integrate with model forms, a new Index.get_unique_checks() was added to communicate to the model which fields should be considered during unique validation.

https://code.djangoproject.com/ticket/20581

@jdufresne
[WIP] Fixed #20581 -- Added class based index Unique and UniqueDeferred.
fa851b7 
UniqueDeferred can be used to create a deferred unique constraint. For
class based unique constraints to integrate with model forms, a new
Index.get_unique_checks() was added to communicate to the model which
fields should be considered during unique validation.
@akki
Copy link
Contributor

akki commented Jun 10, 2017 •
edited
Loading

Thanks for the patch.

There is one point of concern that I have with this approach of making a new class for unique indexes.
Actually "unique" is not a type of index (unlike BTree, Hash, etc.), "unique" is like a property for any index. During the implementation of the index class I had imagined unique as another parameter of the Index class instead of a whole new class (and this was also discussed somewhere on the mailing list but I can't find it right now).
If we go further with this implementation we might end up making indexes like GinUnique, GistUnique, GinUniqueDeferred, GistUniqueDeferred, etc. in the future, so just wanted to highlight this.

@charettes
Copy link
Member

I agree with @akki on this one. I feel like deferred should be a kwarg to a base Constraint subclass which overlaps a bit with #7615.

@jdufresne
Copy link
Member Author

Thanks for the feedback. I'll wait for the other PR to be resolved and try a new patch leveraging the Constraint class.

@jdufresne jdufresne closed this Jun 13, 2017
@jdufresne jdufresne deleted the unique-defer branch June 26, 2017 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jdufresne @akki @charettes