Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add a way to construct django username from the _LDAPUser object #154

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add a way to construct django username from the _LDAPUser object #154

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion django_auth_ldap/backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,9 @@ def ldap_to_django_username(self, username):
def django_to_ldap_username(self, username):
return username

def get_django_username_from_ldap_user(self, ldap_user):
return self.ldap_to_django_username(ldap_user._username)


class _LDAPUser:
"""
Expand Down Expand Up @@ -599,7 +602,7 @@ def _get_or_create_user(self, force_populate=False):
"""
save_user = False

username = self.backend.ldap_to_django_username(self._username)
username = self.backend.get_django_username_from_ldap_user(self)

self._user, built = self.backend.get_or_build_user(username, self)
self._user.ldap_user = self
Expand Down
11 changes: 11 additions & 0 deletions tests/tests.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -405,6 +405,17 @@ def django_to_ldap_username(self, username):
self.assertEqual(user2.ldap_user._username, "alice")
self.assertEqual(user2.ldap_username, "alice")

class MyBackend2(LDAPBackend):
def get_django_username_from_ldap_user(self, ldap_user):
return "ldap_%s" % ldap_user.attrs["sn"][0]

backend = MyBackend2()
user = backend.authenticate(None, username="alice", password="password")

self.assertEqual(user.username, "ldap_adams")
self.assertEqual(user1.ldap_user._username, "alice")
self.assertEqual(user1.ldap_username, "alice")

def test_search_bind(self):
self._init_settings(
USER_SEARCH=LDAPSearch(
Expand Down