Thanks to visit codestin.com
Credit goes to github.com

Skip to content

WIP: BIND_AS_AUTHENTICATING_USER should bind with the authenticating user also when using the Search/Bind configuration #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

WIP: BIND_AS_AUTHENTICATING_USER should bind with the authenticating user also when using the Search/Bind configuration #180

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f752c5f
Fix how BIND_AS_AUTHENTICATING_USER is used, now it does what it says
mari8i Mar 18, 2020
b494594
Stiky is true now
mari8i Mar 18, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions django_auth_ldap/backend.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,13 +476,14 @@ def _authenticate_user_dn(self, password):
Binds to the LDAP server with the user's DN and password. Raises
AuthenticationFailed on failure.
"""
if self.dn is None:
if not self.settings.BIND_AS_AUTHENTICATING_USER and self.dn is None:
raise self.AuthenticationFailed("failed to map the username to a DN.")

try:
sticky = self.settings.BIND_AS_AUTHENTICATING_USER

self._bind_as(self.dn, password, sticky=sticky)
if self.settings.BIND_AS_AUTHENTICATING_USER:
self._bind_as(self._username, password, sticky=True)
else:
self._bind_as(self.dn, password)
except ldap.INVALID_CREDENTIALS:
raise self.AuthenticationFailed("user DN/password rejected by LDAP server.")

Expand Down