Implement rate-limiting of user saves to spare the database #355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempting to resolve Issue #354 .
This PR allows an application admin to set an optional interval in seconds within which
_LDAPUser._get_or_create_user()will not callself._user.save()for the same user again.The intended use is to set
AUTH_LDAP_ALWAYS_UPDATE_USER_THROTTLE_SECto small single-digit values, e.g.3, thereby capping ldap-auth-related SQLUPDATE "auth_user"...commands to no more than 1 every 3 seconds (down from something like 20 every 3 seconds like I recently saw).