Improves unit tests by using self.assertX
instead of raw assert
s
#113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use of raw
assert
s in unit testing is a bit of an anti-pattern asassert
s can be disabled at runtime viapython -O
.This PR converts all of these raw
assert
calls, as well as the use of theeq_
helper function fromnose
to nativeself.assertX
calls provided by theunittest
library. Added a fallback tounittest2
for Python 2.6.Note: the travis tests are failing because of an unpinned version install on
flake8
. If you bump travis to rerunmaster
, it will fail for the same reason due to additional checks introduced inflake8
since travis was last run onmaster
.