Don't cache values() and values_list()
#115
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fallback to unittest2 for Python 2.6.
django-cache-machine's behaviour with the `.values` and `.values_list` methods on a `QuerySet`. That is, not to cache the results.
values() and values_list()
| a = [x for x in Addon.objects.all() if x.id == 1][0] | ||
| assert a.from_cache is False | ||
| self.assertIs(a.from_cache, False) |
There was a problem hiding this comment.
Couldn't this (and all other similar asserts) be rewritten as self.assertFalse(a.from_cache)?
There was a problem hiding this comment.
Yup, it could. I simply performed a regex find and replace from the native asserts to their unit testing method calls.
There was a problem hiding this comment.
If I get the time and motivation, I may take this PR and tweak it to use those assert functions instead then.
Thanks!
|
Thanks. A similar change was included in #125, just merged, so I'll close this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This extends PR #113 with two additional test methods:
test_no_cache_valuesandtest_no_cache_values_list. These methods provide an assertion of the behaviour indicated by the documentation regarding calls to.values()and.values_list(). That is, that queries involving these calls are not cached.This PR was written as a prefix to bug report #116 to do with Django 1.9.
Note: the travis tests are failing because of an unpinned version install on
flake8. If you bump travis to rerunmaster, it will fail for the same reason due to additional checks introduced inflake8since travis was last run onmaster.