Thanks to visit codestin.com
Credit goes to github.com

Skip to content

docs: link pr template link to Discord channel #8257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 15, 2025
Merged

docs: link pr template link to Discord channel #8257

merged 4 commits into from
Jul 15, 2025

Conversation

wesleyboar
Copy link
Contributor

@wesleyboar wesleyboar commented Jun 16, 2025 •
edited
Loading

Description

Linked #pr-reviews channel name to the link for that #pr-reviews channel.

Related resources

  • none

Checklist

Summary by Sourcery

Documentation:

  • Replace plain-text #pr-reviews reference with a hyperlink to the Discord channel in the PULL_REQUEST_TEMPLATE.md

@sourcery-ai Sourcery AI
Copy link
Contributor

sourcery-ai bot commented Jun 16, 2025 •
edited
Loading

Reviewer's Guide

This PR updates the PULL_REQUEST_TEMPLATE by replacing the plain ‘#pr-reviews’ channel reference with a proper Markdown link pointing to the specific Discord channel.

File-Level Changes

Change Details Files
Use a Markdown link for the Discord #pr-reviews channel in the PR template
  • Replaced unlinked channel name with #pr-reviews
  • Ensured the contribution guidelines link remains intact
 .github/PULL_REQUEST_TEMPLATE.md
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@wesleyboar wesleyboar changed the title docs: PULL_REQUEST_TEMPLATE link to Discord channel docs: link pr template link to Discord channel Jun 16, 2025
sourcery-ai[bot]
sourcery-ai bot reviewed Jun 16, 2025
View reviewed changes
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @wesleyboar - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@fsbraun
Copy link
Member

fsbraun commented Jun 17, 2025

@wesleyboar What's is issue with the redirect link https://discord-pr-review-channel.django-cms.org?

@wesleyboar
Copy link
Contributor Author

Oh, I didn't notice that link should redirect to channel. Hm...

That link does not redirect to channel for me.

  1. I have Discord app installed (macOS).
  2. Clicking https://discord-pr-review-channel.django-cms.org/ redirects me to https://discord.com/invite/sEfphsJDgq.
  3. I accept the invite.
  4. Browser asks to launch Discord.
  5. Discord app launches, but does not take me to #pr-reviews channel (it takes me to "Direct Messages" or whatever I last had opened e.g. Settings).
  6. I revisit browser page that opened app.
  7. I dismiss browser prompt.
  8. I instead click button to continue to Discord in browser.
  9. I am (after a few quick redirects) taken to #welcome-and-rules channel.

@wesleyboar
Copy link
Contributor Author

Shall I close this PR and create an issue instead?

That https://discord-pr-review-channel.django-cms.org/ is better, if it worked.

Shall I provide specific information about my env?

@macolo
Copy link
Contributor

macolo commented Jul 11, 2025

Hi @wesleyboar thanks for bringing this to our attention. It looks like this is either a bug that Discord will fix or they have changed the behaviour of their channel invite links and they won't fix this.

I guess we have to provide both links, on link to join the server (can be a general server invite link) and then the direct link to the channel (which can only be used if the user has already joined our server).

It's a bit cumbersome but probably the safest solution, to an otherwise nasty problem.

Shall I close this PR and create an issue instead?

That https://discord-pr-review-channel.django-cms.org/ is better, if it worked.

Shall I provide specific information about my env?

wesleyboar
wesleyboar commented Jul 14, 2025
View reviewed changes
@wesleyboar
docs: tweak wording to offer linsk in order
1f9868f 
Rewritten so user joins server first (and is hopefully taken to correct channel) then offers link to channel (in case not redirected)

https://github.com/django-cms/django-cms/pull/8257/files#r2205293734
@wesleyboar
Copy link
Contributor Author

I guess we have to provide both links, on link to join the server (can be a general server invite link) and then the direct link to the channel (which can only be used if the user has already joined our server).

@macolo, practical. I've tweaked the list item to offer both links in that order.

@codecov Codecov
Copy link

codecov bot commented Jul 15, 2025 •
edited
Loading

Welcome to Codecov 🎉

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered ☂️

@fsbraun fsbraun merged commit e043702 into django-cms:main Jul 15, 2025
67 checks passed
fsbraun added a commit that referenced this pull request Jul 15, 2025
@wesleyboar @fsbraun
docs: link pr template link to Discord channel (#8257)
6a63ef2 
* docs: PULL_REQUEST_TEMPLATE link to Discord channel

* docs: tweak wording to offer linsk in order

Rewritten so user joins server first (and is hopefully taken to correct channel) then offers link to channel (in case not redirected)

https://github.com/django-cms/django-cms/pull/8257/files#r2205293734

---------

Co-authored-by: Fabian Braun <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@fsbraun fsbraun fsbraun approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wesleyboar @fsbraun @macolo