fix: Add default_auto_field to cms/apps.py (#8254)
#8258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: Add `default_auto_field` to cms/apps.py * Add default_autofield to `menus.apss`
Reviewer's GuideThis PR updates the application configurations for the CMS and menus apps by specifying a default primary key field type via the Class diagram for updated AppConfig classes in cms and menus appsclassDiagram
class CMSConfig {
name = 'cms'
verbose_name = _('django CMS')
default_auto_field = 'django.db.models.AutoField'
ready()
}
class MenusConfig {
name = 'menus'
verbose_name = _('django CMS menus system')
default_auto_field = 'django.db.models.AutoField'
}
CMSConfig --|> AppConfig
MenusConfig --|> AppConfig
File-Level Changes
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Hey @fsbraun - I've reviewed your changes - here's some feedback:
- Consider using django.db.models.BigAutoField instead of AutoField to align with Django 3.2+ defaults and avoid future primary key limitations.
- For consistency, add
default_auto_fieldto all other CMS-related AppConfig subclasses (e.g. placeholders, plugins). - There’s a typo in the PR description/commit message (“menus.apss”); update it to “menus.apps” for clarity.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- Consider using django.db.models.BigAutoField instead of AutoField to align with Django 3.2+ defaults and avoid future primary key limitations.
- For consistency, add `default_auto_field` to all other CMS-related AppConfig subclasses (e.g. placeholders, plugins).
- There’s a typo in the PR description/commit message (“menus.apss”); update it to “menus.apps” for clarity.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8258 +/- ##
=======================================
Coverage 89.69% 89.69%
=======================================
Files 129 129
Lines 12733 12734 +1
=======================================
+ Hits 11421 11422 +1
Misses 1312 1312 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Add
default_auto_fieldto cms/apps.pyAdd default_autofield to
menus.appsDescription
Related resources
Checklist
mainSummary by Sourcery
Add
default_auto_fieldattribute to the CMS and Menus application configurationsBug Fixes:
default_auto_field = 'django.db.models.AutoField'inCMSConfigdefault_auto_field = 'django.db.models.AutoField'inMenusConfig