[feat] Database Option #1559
Closed
[feat] Database Option #1559
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
trbs
requested changes
Jul 29, 2020
| parser.add_argument( | ||
| '--show-secrets', | ||
| default=DEFAULT_SECRETS, | ||
| dest='show secrets', |
There was a problem hiding this comment.
please do not use spaces, use underscores.
| @staticmethod | ||
| def get_defaults(options): | ||
| a_options = [ | ||
| options.get('show secrets', DEFAULT_SECRETS), |
There was a problem hiding this comment.
please do not use spaces, use underscores.
| @staticmethod | ||
| def safe_settings(): | ||
| try: | ||
| return SafeExceptionReporterFilter().get_safe_settings() |
There was a problem hiding this comment.
If django < 3.0 does not have this class then the import above will already have failed and this code is meaningless.
Either the comment below is wrong or we should catch ImportError during importing.
FYI: This entire code can be replaced to function at startup time which seem to be preferred to this way if it served no additional function.
| @@ -47,11 +47,17 @@ def add_arguments(self, parser): | |||
| type=bool, | |||
| help="Specifies if should be revealed the value of secrets", | |||
| ) | |||
| parser.add_argument( | |||
| "--database", | |||
| dest="show database", | |||
|
I guess I don't understand what purpose this PR serves... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature requested in the #1467. I added a new option in
print_settings.pyto show the current database. But we need to approve and merge the #1553 PR, because I made some refactoring in this file through this PR