Add setting to fix runserver_plus debugger on custom host names
#1878
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like the test failures are unrelated to my change, or am I missing something? Is there any interest for this change? |
Yes, this change, or something like it, is vital for |
|
Given this project appears to be moribund, the following work-around can be used to avoid having to pin Werkzeug to <3.0.3. Put the following in your import werkzeug.debug
werkzeug.debug.DebuggedApplication.check_host_trust = (
lambda *args, **kwargs: True # noqa: ARG005
) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
RUNSERVERPLUS_TRUSTED_HOSTSsetting to work with Werkzeug 3.0.3+ debugger.Werkzeug version 3.0.3 introduced a fix for a security vulnerability:
I'm running
runserver_pluswith Werkzeug 3.0.3 on a machine with a custom dev host (e.g.dev.mydomain.com) which means that the Werkzeug debugger no longer works.As far as I could tell, there was no way to tell Werkzeug to trust my dev host, so adding this option to do so.
Questions
settings.ALLOWED_HOSTS? It might be a good enough default on a Django project...