Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add setuptools to fix failing tests on Python 3.12 #1963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Apr 30, 2024
Merged

Add setuptools to fix failing tests on Python 3.12 #1963

merged 7 commits into from
Apr 30, 2024

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Apr 29, 2024

@claudep
Copy link
Contributor

claudep commented Apr 29, 2024

I guess a new pysolr release is needed to fix the issue on Python 3.12.

@cclauss
Copy link
Contributor Author

cclauss commented Apr 29, 2024 •
edited
Loading

Just needed setuptools on Python 3.12.

python3.12/site-packages/pysolr.py", line 14, in <module>
      from pkg_resources import DistributionNotFound, get_distribution, parse_version
  ModuleNotFoundError: No module named 'pkg_resources'

This was done in pysolr repo in django-haystack/pysolr#425

@cclauss cclauss requested a review from claudep April 29, 2024 21:07
@cclauss cclauss changed the title WIP: Expose failures with Python 3.12 Add setuptools to fix failing tests on Python 3.12 Apr 29, 2024
@cclauss cclauss requested a review from acdha April 29, 2024 22:05
claudep
claudep reviewed Apr 30, 2024
View reviewed changes
@cclauss cclauss requested a review from claudep April 30, 2024 06:47
@claudep
Copy link
Contributor

claudep commented Apr 30, 2024

Thanks, what about squashing commits?

@cclauss
Copy link
Contributor Author

cclauss commented Apr 30, 2024

I almost always Squash and merge unless the individual commits tell a story that is vital to preserve.

Screenshot 2024-04-30 at 11 31 59

claudep
claudep approved these changes Apr 30, 2024
View reviewed changes
Copy link
Contributor

@claudep claudep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@claudep claudep merged commit c83a281 into master Apr 30, 2024
@claudep claudep deleted the Expose-failures-with-Python-3.12 branch April 30, 2024 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@claudep claudep claudep approved these changes

@acdha acdha Awaiting requested review from acdha

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cclauss @claudep