Thanks to visit codestin.com
Credit goes to github.com

Skip to content

compatible with Python 3.12 #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

piranna
Copy link

@piranna piranna commented Sep 19, 2024

Fix #49

@piranna
Copy link
Author

piranna commented Nov 14, 2024

Any update on this? Can we get it merged?

@piranna
Copy link
Author

piranna commented Nov 14, 2024

I've fixed #51 here too, by upgrading to use pyproject.toml file.

kra3
kra3 previously approved these changes Nov 17, 2024
@kra3
Copy link
Member

kra3 commented Nov 17, 2024

@piranna thanks a lot for addressing the concerns and upgrading the build tooling to poetry.

I have also realised travis integration is broken, so I've replaced travis with GitHub workflows (#45).
Could you please kind enough to rebase the PR branch to main branch. Once the build pass, I will cut a release.

@piranna
Copy link
Author

piranna commented Nov 18, 2024

thanks a lot for addressing the concerns and upgrading the build tooling to poetry.

You are welcome.

Could you please kind enough to rebase the PR branch to main branch.

Done, can you review it?

@kra3
Copy link
Member

kra3 commented Nov 21, 2024

unfortunately, tests are failing here (needs to update workflows to use poetry).
However test are failing for me locally poetry run pytest.
Ware you able to run tests successfully in your local machine ? how are you running tests ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Not compatible with Python 3.12
2 participants