Hotfix- authorization_code_expire_seconds docs clarified #1212
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1212 +/- ##
=======================================
Coverage 96.20% 96.20%
=======================================
Files 26 26
Lines 1317 1317
=======================================
Hits 1267 1267
Misses 50 50 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
n2ygk
requested changes
Oct 21, 2022
docs/settings.rst
Outdated
| token after this duration will fail. :rfc:`4.1.2` recommends a | ||
| 10 minutes (600 seconds) duration. | ||
| token after this duration will fail. :rfc:`4.1.2` recommends expire after a short lifetime, | ||
| being 10 minutes (600 seconds) the maximum acceptable. |
There was a problem hiding this comment.
Suggested change
| being 10 minutes (600 seconds) the maximum acceptable. | |
| with 10 minutes (600 seconds) being the maximum acceptable. |
n2ygk
approved these changes
Oct 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1211
Description of the Change
Fix confusing documentation about
AUTHORIZATION_CODE_EXPIRE_SECONDS.Matching
DefaultACCESS_TOKEN_EXPIRE_SECONDSlike in the other settings in docs.Checklist
CHANGELOG.mdupdated (only for user relevant changes)AUTHORS