Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

PetrDlouhy
Copy link
Contributor

Few upgrades to make admin better arranged.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 1124

  • 7 of 7 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.02%) to 94.721%

Totals Coverage Status
Change from base Build 1114: 0.02%
Covered Lines: 1256
Relevant Lines: 1326

💛 - Coveralls

Copy link
Contributor

@IvanAnishchuk IvanAnishchuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if assuming things regarding user model is a good approach here. Otherwise good changes.

class GrantAdmin(admin.ModelAdmin):
list_display = ("code", "application", "user", "expires")
raw_id_fields = ("user", )
search_fields = ("code", "user__email")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm... You sure this won't break things it user model doesn't have a email field?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1. Rest looks good.

@MattBlack85
Copy link
Contributor

closing due lack of tests at this moment, feel free to re-open in case!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants