Thanks to visit codestin.com
Credit goes to github.com

Skip to content

pkce in oauthlib 3.1.0 #825

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Apr 9, 2020
Merged

pkce in oauthlib 3.1.0 #825

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8273e9c
pkce in oauthlib 3.1.0
dulmandakh Apr 8, 2020
3d87616
oauthlib 3.1.0
dulmandakh Apr 9, 2020
9ee1136
fix docs
dulmandakh Apr 9, 2020
a974cd1
sphinx<3
dulmandakh Apr 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ Requirements

* Python 3.5+
* Django 2.1+
* oauthlib 3.0+
* oauthlib 3.1+

Installation
------------
Expand Down
2 changes: 1 addition & 1 deletion docs/index.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ Requirements

* Python 3.5+
* Django 2.1+
* oauthlib 3.0+
* oauthlib 3.1+

Index
=====
Expand Down
2 changes: 1 addition & 1 deletion docs/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
Django>=3.0,<3.1
oauthlib>=3.0.1
oauthlib>=3.1.0
m2r>=0.2.1
.
12 changes: 0 additions & 12 deletions oauth2_provider/views/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,16 +139,6 @@ def form_valid(self, form):
def get(self, request, *args, **kwargs):
try:
scopes, credentials = self.validate_authorization_request(request)
# TODO: Remove the two following lines after oauthlib updates its implementation
# https://github.com/jazzband/django-oauth-toolkit/pull/707#issuecomment-485011945
credentials["code_challenge"] = credentials.get(
"code_challenge",
request.GET.get("code_challenge", None)
)
credentials["code_challenge_method"] = credentials.get(
"code_challenge_method",
request.GET.get("code_challenge_method", None)
)
except OAuthToolkitError as error:
# Application is not available at this time.
return self.error_response(error, application=None)
Expand All @@ -166,8 +156,6 @@ def get(self, request, *args, **kwargs):
kwargs["redirect_uri"] = credentials["redirect_uri"]
kwargs["response_type"] = credentials["response_type"]
kwargs["state"] = credentials["state"]
kwargs["code_challenge"] = credentials["code_challenge"]
kwargs["code_challenge_method"] = credentials["code_challenge_method"]

self.oauth2_data = kwargs
# following two loc are here only because of https://code.djangoproject.com/ticket/17795
Expand Down
2 changes: 1 addition & 1 deletion setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ zip_safe = False
install_requires =
django >= 2.1
requests >= 2.13.0
oauthlib >= 3.0.1
oauthlib >= 3.1.0

[options.packages.find]
exclude = tests
Expand Down
6 changes: 3 additions & 3 deletions tox.ini
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ deps =
django30: Django>=3.0,<3.1
djangomaster: https://github.com/django/django/archive/master.tar.gz
djangorestframework
oauthlib>=3.0.1
oauthlib>=3.1.0
coverage
pytest
pytest-cov
Expand All @@ -39,8 +39,8 @@ basepython = python
changedir = docs
whitelist_externals = make
commands = make html
deps = sphinx
oauthlib>=3.0.1
deps = sphinx<3
oauthlib>=3.1.0
m2r>=0.2.1

[testenv:py37-flake8]
Expand Down