Thanks for your pull request and interest in making D better, @pbackus! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

• My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
• My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
• I have provided a detailed rationale explaining my changes
• New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

• In preparation for migrating from Bugzilla to GitHub Issues, the issue reference syntax has changed. Please add the word "Bugzilla" to issue references. For example, Fix Bugzilla Issue 12345 or Fix Bugzilla 12345.(Reminder: the edit needs to be done in the Git commit message, not the GitHub pull request.)

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#10652"

Style check is going to fail because of dlang-community/D-Scanner#956

CC @LightBender

Naming nit:
writeWtext = writeWText
writeDtext = writeDText

The current names were chosen to be consistent with text, wtext, and dtext, which do not capitalize the word "text." I don't mind changing them if we think quality of new names is more important than consistency with old ones, though.

In v3 those methods are getting renamed. Likely to something like asText, asWText, and asDText. There is a thread about these names in the v3 design repo.

Ok; I'll assume you're bringing this up because you think that we should also follow this Phobos v3 naming convention when adding new symbols to Phobos v2, even if it breaks consistency with existing v2 symbols.

TBH, I've gone round and round on the idea of V2 names following the V3 conventions even if that breaks consistency, both with others and with myself.

And where I've landed on it is: Every name that does not change between versions is one less bit of friction to the process of upgrading your code to V3. It's already going to be an unpleasant chore, anything that makes it easier will help convince people to make the switch.

Backup of the original branch: https://github.com/0xEAB/phobos/tree/fix-gh-10550-backup

@0xEAB Is there a reason you've force-pushed on top of my PR?

Ok, looks like you've rebased onto current master. Next time, please just notify me so that I can do it myself. I actually have an unpublished commit on this branch (adding a changelog entry), and now I'm going to have to clean up your mess in order to push it.

Rebased, added changelog, and disabled "Allow edits by maintainers," since apparently that's a privilege that not everyone here can be trusted with. Ping me if you need it re-enabled.

Ok, looks like you've rebased onto current master. Next time, please just notify me so that I can do it myself.

Sorry, will do so.

Rebased, added changelog, and disabled "Allow edits by maintainers," since apparently that's a privilege that not everyone here can be trusted with.

• I was curious whether the D-Scanner issue was still a thing, given that at least libdparse had been updated.
• Also, another PR of mine had caused a conflict with this one already.
• Given that this PR looked quite “finished” (and was suffering only from the external style checking incompatibility), I figured you wouldn’t mind having it rebased for you. I’m sorry.

Rebased again to include #10720