std.typecons: Make Nullable.toString always a template #10767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because some overloads of Nullable!T.toString are not templates, instantiating a Nullable!T also always instantiates formatValue!T, and all of its dependencies. For large type hierarchies, this can add a significant amount of compilation overhead. We can avoid this by making remaining overloads of Nullable!T.toString templates as well, similar to Tuple. Timings from internal motivating use case: Before: 9.00user 1.38system 0:10.57elapsed 98%CPU (0avgtext+0avgdata 5851516maxresident)k 21968inputs+48144outputs (0major+1468687minor)pagefaults 0swaps After: 5.11user 0.61system 0:05.75elapsed 99%CPU (0avgtext+0avgdata 2762392maxresident)k 0inputs+34528outputs (0major+685900minor)pagefaults 0swaps
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because some overloads of
Nullable!T.toStringare not templates, instantiating aNullable!Talso always instantiatesformatValue!T, and all of its dependencies.For large type hierarchies, this can add a significant amount of compilation overhead.
We can avoid this by making remaining overloads of
Nullable!T.toStringtemplates as well, similar toTuple.Timings from internal motivating use case:
Before:
After: