std.file.rename: avoid segfault on null string (#10727) #10768
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added null-checks on fromz/toz before slicing, so rename(null, …) or rename(…, null) no longer crashes. - Added runtime unittest to assert FileException is thrown for null inputs.
|
Is this a duplicate of #10736? Looks like that one targeted the |
|
Yes, please target the stable branch. |
|
Closing in favor of the stable branch PR #10769 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10727: std.file.rename segfaults when source or destination is null on Windows.
fromzandtozbefore calling wcslen.(rename("", null) and rename(null, "")).