workaround DCD linker error #492
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ PR OK, no changes in deprecations or warnings Total deprecations: 0 Total warnings: 0 Build statistics: ------ libdparse statistics ------
statistics (-before, +after)
-library size=3510668 libdparse.a
+library size=3511132 libdparse.a
rough build time=22s
------ DCD statistics ------
statistics (-before, +after)
client size=1055768 bin/dcd-client
server size=3018608 bin/dcd-server
-rough build time=101s
+rough build time=102s
-DCD run_tests.sh Elapsed (wall clock) time (h:mm:ss or m:ss): 0:05.96
-DCD run_tests.sh Maximum resident set size (kbytes): 13288
+DCD run_tests.sh Elapsed (wall clock) time (h:mm:ss or m:ss): 0:06.01
+DCD run_tests.sh Maximum resident set size (kbytes): 7872
short requests: (215x)
- min request time = 0.010ms
- 10th percentile = 0.145ms
- median time = 0.507ms
- 90th percentile = 0.870ms
- max request time = 2.153ms
+ min request time = 0.013ms
+ 10th percentile = 0.164ms
+ median time = 0.531ms
+ 90th percentile = 0.946ms
+ max request time = 1.698ms
top 5 GC sources in server:
+bytes allocated, allocations, type, function, file:line
+ 7554112 81399 void[] std.array.Appender!(DSymbol*[]).Appender.ensureAddable.__lambda9 /opt/hostedtoolcache/dc/dmd-2.102.2/x64/dmd2/linux/bin64/../../src/phobos/std/array.d:3577
+ 3768320 460 void[] std.array.Appender!(TokenStructure!(ubyte, "\n import dparse.lexer : Token;\n\n this(Token token) pure nothrow @safe @nogc {\n this(token.type, token.text, token.line, token.column, token.index);\n }\n\n int opCmp(size_t i) const pure nothrow @safe @nogc {\n if (index < i) return -1;\n if (index > i) return 1;\n return 0;\n }\n\n int opCmp(ref const typeof(this) other) const pure nothrow @safe @nogc {\n return opCmp(other.index);\n }\n")[]).Appender.ensureAddable.__lambda9 /opt/hostedtoolcache/dc/dmd-2.102.2/x64/dmd2/linux/bin64/../../src/phobos/std/array.d:3577
+ 2277376 278 void[] std.array.Appender!(char[][]).Appender.ensureAddable.__lambda9 /opt/hostedtoolcache/dc/dmd-2.102.2/x64/dmd2/linux/bin64/../../src/phobos/std/array.d:3577
+ 1830176 57193 std.array.Appender!(dsymbol.symbol.DSymbol*[]).Appender.Data std.array.Appender!(DSymbol*[]).Appender.this /opt/hostedtoolcache/dc/dmd-2.102.2/x64/dmd2/linux/bin64/../../src/phobos/std/array.d:3452
+ 1422336 603 void[] std.array.Appender!(const(TokenStructure!(ubyte, "import dparse.lexer:TokenTriviaFields,TriviaToken; mixin TokenTriviaFields;"))[]).Appender.ensureAddable.__lambda9 /opt/hostedtoolcache/dc/dmd-2.102.2/x64/dmd2/linux/bin64/../../src/phobos/std/array.d:3577Full build output |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #492 +/- ##
==========================================
- Coverage 83.49% 83.46% -0.03%
==========================================
Files 11 11
Lines 8483 8493 +10
==========================================
+ Hits 7083 7089 +6
- Misses 1400 1404 +4
Continue to review full report in Codecov by Sentry.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is stupid, but it works