steelMemberShearPanel - Types for Steel Design #110

dogukankaratas · 2022-03-22T15:03:33Z

steelMemberShearPanel class has added.
Enumeration items created. (Some fixes has done in enumeration -there were identical classes, they're removed.)
Unit test has added.

OndraMichal · 2022-03-30T10:10:04Z

UnitTests/test_steelMemberShearPanel.py

+)
+sys.path.append(PROJECT_ROOT)
+
+from RFEM.enums import *


Please specify the imported enum. I think it should be just 3.

OndraMichal · 2022-03-30T10:13:54Z

RFEM/TypesForSteelDesign/steelMemberShearPanel.py

+                comment: str = '',
+                params: dict = {}):
+        """
+        Args:


I think the argument section could be shorter, not specifying every case. Or at least specify first all arguments and then add any informatio necessary for understanding. I think we don't have to copy whole logic into dosctring. If user wants to know the logic, he ca nread it from the body of the method.
What do you think?

Can be done, but didn't want to delete when it's already there :) I will be more specific next time.

OndraMichal · 2022-03-30T10:18:48Z

RFEM/TypesForSteelDesign/steelMemberShearPanel.py

+                categories = [SteelMemberShearPanelPositionOnSection.POSITION_ON_UPPER_FLANGE, "FI (+) 35/207 - 0.63 (b: 1) | DIN 18807 | Fischer Profil", SteelMemberShearPanelFasteningArrangement.FASTENING_ARRANGEMENT_EVERY_RIB],
+                parameters = [1, 2, 0.000247, 0.01043],
+                comment: str = '',
+                params: dict = {}):


default dict value is now None in the main branch. Then add if before params assignment to clentObject.

if params: for key in params: clientObject[key] = params[key]

OndraMichal · 2022-03-30T10:19:25Z

UnitTests/test_steelMemberShearPanel.py

+    assert shearPanel_3.panel_length == 2.0
+
+
+    Model.clientModel.service.finish_modification()


Add empty line at the end :-)

…emberShearPanelTypesForSteelDesign

pull-request-quantifier-deprecated · 2022-04-27T05:44:20Z

This PR has 256 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details

Label      : Large
Size       : +231 -25
Percentile : 65.6%

Total files changed: 6

Change summary by file extension:
.py : +231 -25

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

Fast and predictable releases to production:
- Optimal size changes are more likely to be reviewed faster with fewer
  iterations.
- Similarity in low PR complexity drives similar review times.
Review quality is likely higher as complexity is lower:
- Bugs are more likely to be detected.
- Code inconsistencies are more likely to be detetcted.
Knowledge sharing is improved within the participants:
- Small portions can be assimilated better.
Better engineering practices are exercised:
- Solving big problems by dividing them in well contained, smaller problems.
- Exercising separation of concerns within the code changes.

What can I do to optimize my changes

Use the PullRequestQuantifier to quantify your PR accurately
- Create a context profile for your repo using the context generator
- Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
- Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
- Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
Change your engineering behaviors
- For PRs that fall outside of the desired spectrum, review the details and check if:
  - Your PR could be split in smaller, self-contained PRs instead
  - Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

One line was added: +1 -0
One line was deleted: +0 -1
One line was modified: +1 -1 (git diff doesn't know about modified, it will
interpret that line like one addition plus one deletion)
Change percentiles: Change characteristics (addition, deletion, modification)
of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍 :ok_hand: :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

added steelMemberShearPanel

4f5e36f

dogukankaratas requested a review from OndraMichal March 22, 2022 15:03

pull-request-quantifier-deprecated bot added the Large label Mar 22, 2022

OndraMichal requested changes Mar 30, 2022

View reviewed changes

KaratasD and others added 3 commits April 26, 2022 15:54

Update steelMemberShearPanel

597e5a6

Update steelMemberShearPanel

ddb6bf1

Merge remote-tracking branch 'remotes/origin/main' into dogukaratas-m…

f5dd1e0

…emberShearPanelTypesForSteelDesign

OndraMichal approved these changes Apr 27, 2022

View reviewed changes

OndraMichal merged commit 12f03da into main Apr 27, 2022

OndraMichal deleted the dogukaratas-memberShearPanelTypesForSteelDesign branch April 27, 2022 05:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

steelMemberShearPanel - Types for Steel Design #110

steelMemberShearPanel - Types for Steel Design #110

Uh oh!

dogukankaratas commented Mar 22, 2022

Uh oh!

OndraMichal Mar 30, 2022 •

edited

Loading

Uh oh!

dogukankaratas Apr 26, 2022

Uh oh!

OndraMichal Mar 30, 2022

Uh oh!

dogukankaratas Apr 26, 2022

Uh oh!

OndraMichal Mar 30, 2022

Uh oh!

dogukankaratas Apr 26, 2022

Uh oh!

OndraMichal Mar 30, 2022

Uh oh!

dogukankaratas Apr 26, 2022

Uh oh!

pull-request-quantifier-deprecated bot commented Apr 27, 2022

What can I do to optimize my changes

How to interpret the change counts in git diff output

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		assert shearPanel_3.panel_length == 2.0


		Model.clientModel.service.finish_modification() No newline at end of file

steelMemberShearPanel - Types for Steel Design #110

steelMemberShearPanel - Types for Steel Design #110

Uh oh!

Conversation

dogukankaratas commented Mar 22, 2022

Uh oh!

OndraMichal Mar 30, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dogukankaratas Apr 26, 2022

Choose a reason for hiding this comment

Uh oh!

OndraMichal Mar 30, 2022

Choose a reason for hiding this comment

Uh oh!

dogukankaratas Apr 26, 2022

Choose a reason for hiding this comment

Uh oh!

OndraMichal Mar 30, 2022

Choose a reason for hiding this comment

Uh oh!

dogukankaratas Apr 26, 2022

Choose a reason for hiding this comment

Uh oh!

OndraMichal Mar 30, 2022

Choose a reason for hiding this comment

Uh oh!

dogukankaratas Apr 26, 2022

Choose a reason for hiding this comment

Uh oh!

pull-request-quantifier-deprecated bot commented Apr 27, 2022

What can I do to optimize my changes

How to interpret the change counts in git diff output

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

OndraMichal Mar 30, 2022 •

edited

Loading