Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Update to latest RFEM #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
May 29, 2023
Merged

Update to latest RFEM #258

merged 7 commits into from
May 29, 2023

Conversation

OndraMichal
Copy link
Contributor

@OndraMichal OndraMichal commented May 24, 2023 •
edited
Loading

Description

This change concludes all changes needed so that client can work with latest RFEM. All versions 6.02.0065 should work.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

How Has This Been Tested?

  • Unit Tests
  • Attached examples

Test Configuration:

  • RFEM / RSTAB version: 6.02.0065.149.7baec1cb242
  • Python version: 3.11.3

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

heetrojivadiya
heetrojivadiya requested changes May 24, 2023
View reviewed changes
RFEM/TypesForMembers/memberSupport.py
clientObject.spring_translation_x = spring_translation_x
clientObject.spring_translation_y = spring_translation_y
clientObject.spring_translation_z = spring_translation_z[0]
clientObject.nonlinearity = spring_translation_z[1].name
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In newer version, name of nonlinearity for translation_z is changed to 'nonlinearity_translational_z' but it is available and accessible with wsdl.

image

image

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

RFEM/initModel.py Outdated

# Check if port is listening
a_socket = socket.socket(socket.AF_INET, socket.SOCK_STREAM)
#a_socket.settimeout(360)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

commented code line should be removed

heetrojivadiya
heetrojivadiya reviewed May 25, 2023
View reviewed changes
Copy link
Member

@heetrojivadiya heetrojivadiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes in new commit seems okay and all new changed unittests are passed. Still two previous comments are not addressed in this commit.

@pull-request-quantifier-deprecated
Copy link

This PR has 388 quantified lines of changes. In general, a change size of upto 200 lines is ideal for the best PR experience!

Quantification details 

Label      : Large
Size       : +155 -233
Percentile : 78.8%

Total files changed: 41

Change summary by file extension:
.py : +155 -233

Change counts above are quantified counts, based on the PullRequestQuantifier customizations.

Why proper sizing of changes matters

Optimal pull request sizes drive a better predictable PR flow as they strike a
balance between between PR complexity and PR review overhead. PRs within the
optimal size (typical small, or medium sized PRs) mean:

  • Fast and predictable releases to production:
    • Optimal size changes are more likely to be reviewed faster with fewer
      iterations.
    • Similarity in low PR complexity drives similar review times.
  • Review quality is likely higher as complexity is lower:
    • Bugs are more likely to be detected.
    • Code inconsistencies are more likely to be detected.
  • Knowledge sharing is improved within the participants:
    • Small portions can be assimilated better.
  • Better engineering practices are exercised:
    • Solving big problems by dividing them in well contained, smaller problems.
    • Exercising separation of concerns within the code changes.

What can I do to optimize my changes

  • Use the PullRequestQuantifier to quantify your PR accurately
    • Create a context profile for your repo using the context generator
    • Exclude files that are not necessary to be reviewed or do not increase the review complexity. Example: Autogenerated code, docs, project IDE setting files, binaries, etc. Check out the Excluded section from your prquantifier.yaml context profile.
    • Understand your typical change complexity, drive towards the desired complexity by adjusting the label mapping in your prquantifier.yaml context profile.
    • Only use the labels that matter to you, see context specification to customize your prquantifier.yaml context profile.
  • Change your engineering behaviors
    • For PRs that fall outside of the desired spectrum, review the details and check if:
      • Your PR could be split in smaller, self-contained PRs instead
      • Your PR only solves one particular issue. (For example, don't refactor and code new features in the same PR).

How to interpret the change counts in git diff output

  • One line was added: +1 -0
  • One line was deleted: +0 -1
  • One line was modified: +1 -1 (git diff doesn't know about modified, it will
    interpret that line like one addition plus one deletion)
  • Change percentiles: Change characteristics (addition, deletion, modification)
    of this PR in relation to all other PRs within the repository.

Was this comment helpful? 👍  :ok_hand:  :thumbsdown: (Email)
Customize PullRequestQuantifier for this repository.

@OndraMichal OndraMichal merged commit 1f3aa02 into main May 29, 2023
@OndraMichal OndraMichal deleted the OndrejMichal_update_to_latest_RFEM branch May 29, 2023 06:56
heetrojivadiya
heetrojivadiya reviewed May 30, 2023
View reviewed changes
RFEM/BasicObjects/member.py
end_section_no: int = 1,
rib_surfaces_no = [],
rib_alignment = MemberTypeRibAlignment.ALIGNMENT_ON_Z_SIDE_POSITIVE,
reference_width_type = MemberReferenceLengthWidthType.REFERENCE_LENGTH_WIDTH_SIXTH,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be also updated in docstrings too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@heetrojivadiya heetrojivadiya heetrojivadiya requested changes

@dogukankaratas dogukankaratas Awaiting requested review from dogukankaratas

Assignees

No one assigned

Labels

Large

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@OndraMichal @heetrojivadiya