let monitor know we are restarting a container #13199
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2c244d3 to
3434c6f
Compare
Signed-off-by: Nicolas De Loof <[email protected]>
3434c6f to
241c081
Compare
This was referenced Sep 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Monitor can't guess container is going to restart, as the event it receives after a
ContainerRestartAPI call iskill,stop,die(thenstartand eventuallyrestart)We could wait a few after
stop|dieto check we don't receive arestartevent. But (at least) for commands managed inside the same compose process we can notify the monitor about our intent to restart a container, so it doesn't have toRelated issue
fixes #13161
(not mandatory) A picture of a cute animal, if possible in relation to what you did