fix(run): Ensure images exist only for the target service in run command #13325
+163
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Suleiman Dibirov <[email protected]>
Signed-off-by: Suleiman Dibirov <[email protected]>
ndeloof
approved these changes
Oct 28, 2025
Signed-off-by: Suleiman Dibirov <[email protected]>
glours
approved these changes
Oct 28, 2025
|
It's strange... the tests work fine locally |
Signed-off-by: Suleiman Dibirov <[email protected]>
|
Looks like it was a parallel issue. Should I return the parallel execution and try to fix the issue, or is it ok to leave non-parallel execution? |
|
Yes fix it please, use |
This reverts commit e4f4a5a. Signed-off-by: Suleiman Dibirov <[email protected]>
…es for Docker Compose commands. Signed-off-by: Suleiman Dibirov <[email protected]>
|
done |
glours
approved these changes
Oct 29, 2025
tmeijn
pushed a commit
to tmeijn/dotfiles
that referenced
this pull request
Nov 3, 2025
This MR contains the following updates: | Package | Update | Change | |---|---|---| | [docker/compose](https://github.com/docker/compose) | patch | `v2.40.2` -> `v2.40.3` | MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot). **Proposed changes to behavior should be submitted there as MRs.** --- ### Release Notes <details> <summary>docker/compose (docker/compose)</summary> ### [`v2.40.3`](https://github.com/docker/compose/releases/tag/v2.40.3) [Compare Source](docker/compose@v2.40.2...v2.40.3) #### What's Changed ##### 🐛 Fixes - Fix OCI compose override support by [@​ndeloof](https://github.com/ndeloof) [#​13311](docker/compose#13311) - Fix help output for "exec --no-tty" option by [@​tonyo](https://github.com/tonyo) [#​13314](docker/compose#13314) - Prompt default implementation to prevent a panic by [@​ndeloof](https://github.com/ndeloof) [#​13317](docker/compose#13317) - Run hooks on restart by [@​ndeloof](https://github.com/ndeloof) [#​13321](docker/compose#13321) - Fix(run): Ensure images exist only for the target service in run command by [@​idsulik](https://github.com/idsulik) [#​13325](docker/compose#13325) - Fix(git): Fix path traversal vulnerability in git remote loader by [@​idsulik](https://github.com/idsulik) [#​13331](docker/compose#13331) ##### 🔧 Internal - Test to check writeComposeFile detects invalid OCI artifact by [@​ndeloof](https://github.com/ndeloof) [#​13309](docker/compose#13309) - Code Cleanup by [@​ndeloof](https://github.com/ndeloof) [#​13315](docker/compose#13315) ##### ⚙️ Dependencies - Bump compose-go to version v2.9.1 by [@​glours](https://github.com/glours) [#​13332](docker/compose#13332) **Full Changelog**: <docker/compose@v2.40.2...v2.40.3> </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever MR is behind base branch, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this MR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box --- This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0MS4xNjkuMSIsInVwZGF0ZWRJblZlciI6IjQxLjE2OS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6WyJSZW5vdmF0ZSBCb3QiXX0=-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Fixed a bug where services with
pull_policy: buildwere built twice during docker compose run when they were dependencies of the target service. The issue occurred because ensureImagesExists was called twice - once for dependencies instartDependenciesand again for the full project inprepareRun. ModifiedprepareRunto restrict the secondensureImagesExistscall to only build the target service by filteringBuildOptions.Services.Related issue
#13323