-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Merge master into vnext-opensource #430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge master into vnext-opensource #430
Conversation
Add ELK stack example to UCP logging
Update docker/dtr image reference
Signed-off-by: Victoria Bialas <[email protected]>
Update 3_prepare_the_app.md with missing dots
…in-machine-docs incorporated Misty's rewrite from pr#256 with additional info
Signed-off-by: Victoria Bialas <[email protected]>
added beta 29 release notes for mac and win
Corrected the uninstall command to make it copypasteable (it was missing a \ at the end of the volume argument) and also updated the expected output to include the WARN messages that will appear. Also corrected ordered list numbering (cosmetic only while editing)
Add doc for firewall auto-detection
Signed-off-by: LRubin <[email protected]>
Signed-off-by: LRubin <[email protected]>
Signed-off-by: Victoria Bialas <[email protected]>
update autotest descriptions
finishing touches on Wordpress example in Compose docs per pr#129
Docker Cloud: update tag mapping label, some typo fixes
Signed-off-by: LRubin <[email protected]>
Docker Cloud: updates for multiple email address management
Revert "Doc change to support custom userdata option for docker-machine AWS driver"
Changing note format back to the way it was to match the rest of the notes in this section.
Added a filename above the custom script to distinguish it from the wait-for-it.sh script.
Signed-off-by: Thomas Sjögren <[email protected]>
(cherry picked from commit 46cdf5a8b80791f6d1cb6462dd66e23266a06d33)
(cherry picked from commit adaa077d3cecdfd71bcb640cef942086e4a42d9a)
absolute links to docs.docker.com are now relative links
Signed-off-by: Victoria Bialas <[email protected]>
clarify how to use Windows containers and Windows Server 2016
Fix regex capture groups syntax
fix: Add line breaks before and after code blocks
Migrates DTR 2.0 docs with history
CLOUD-3129 Docker Hub: update hub docs to include cancel button
Migrates UCP 1.1 docs with history
@@ -1,254 +0,0 @@ | |||
# Generate AUTHORS: hack/generate-authors.sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we not going to do an AUTHORS file?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea, but we removed that in master
so removing it here. We don't have that whole hack
directory. Can you raise a separate PR and explain what the AUTHORS
file is for, so we can see if we need it for the docs repo? Please assign it to John.
# Expose port 27017 from the container to the host | ||
EXPOSE 27017 | ||
```dockerfile | ||
# Expose port 27017 from the container to the host |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, something we should fix "expose" doesn't actually expose, it only adds metadata to the dockerfile to describe that the image "exposes" a certain port (it's used for the -P
(publish all) option)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, but that's not really in scope for this PR.
> **Note:** | ||
> | ||
> The full version of this `Dockerfile` can be found [here](https://github.com/docker/docker/blob/master/docs/examples/mongodb/Dockerfile). | ||
> **Note:** The full version of this `Dockerfile` can be found [here](https://github.com/docker/docker/blob/master/docs/examples/mongodb/Dockerfile). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like we need to update this URL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created #434 for this, since it has nothing to do with this specific merge.
```json | ||
{ | ||
"authorization-plugins": [], | ||
"dns": [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
these are gonna be tricky when merging back to docker/docker, because I think new options were added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They won't be merged back at all. Instead, the contents will be re-copied from docker/docker
at some point in the future, at which point the newly added options would show up.
|
||
Instead of specifying a context, you can pass a single Dockerfile in the `URL` | ||
or pipe the file in via `STDIN`. To pipe a Dockerfile from `STDIN`: | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure this should be removed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was done in 7b41a45 which may need to be reverted in master
. I'll check into it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Found one change that we need to check, and some non-related changes that we may want to look into on master
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Few tweaks on check Update with comments from Dan Last comments;fix some build breaks Tighten language add reconfigure info Signed-off-by: Mary Anthony <[email protected]>
* Add DTR 2.5 release notes * Add redirect
* Add DTR 2.5 release notes * Add redirect
Describe the proposed changes
Pick up recent fixes since the migration
Project version
opensource next
Related issue
n/a
Related issue or PR in another project
n/a
Please take a look
@johndmulhausen @thaJeztah