Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix syntax for passing options to volume create #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 29, 2016
Merged

Fix syntax for passing options to volume create #627

merged 1 commit into from
Nov 29, 2016

Conversation

mdlinville
Copy link

Describe the proposed changes

Fix syntax mistake when passing options to volume create.

Related issue

Fixes #325

Please take a look

@dusek @lybrus

@johndmulhausen
Copy link
Contributor

Deploy preview ready!

Built with commit 13dc845

https://deploy-preview-627--docker-docs.netlify.com

@johndmulhausen
Copy link
Contributor

@mstanleyjones Are you sure it's supposed to have two equals signs like that?

$ docker volume create --help

Usage:	docker volume create [OPTIONS]

Create a volume

Options:
  -d, --driver string   Specify volume driver name (default "local")
      --help            Print usage
      --label value     Set metadata for a volume (default [])
      --name string     Specify volume name
  -o, --opt value       Set driver specific options (default map[])

@mdlinville
Copy link
Author

Yep, we have a few like that. @thaJeztah may have some history on it.

@thaJeztah
Copy link
Member

I think it depends if it's a plugin option, or a mount option. Ping @cpuguy83 for a quick look, because I may be confused

@cpuguy83
Copy link
Contributor

LGTM

@thaJeztah thaJeztah merged commit 951b19a into master Nov 29, 2016
@johndmulhausen
Copy link
Contributor

Thanks, all :)

@johndmulhausen johndmulhausen deleted the 325_volume_create_opt_syntax branch November 29, 2016 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mdlinville @johndmulhausen @thaJeztah @cpuguy83