This repository was archived by the owner on Jan 21, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 267
Instance + Flavor Plugin SPI Changes #371
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: David Chung <[email protected]>
Signed-off-by: David Chung <[email protected]>
|
Please sign your commits following these rules: $ git clone -b "spi-tagging" [email protected]:chungers/infrakit.git somewhere
$ cd somewhere
$ git rebase -i HEAD~842353855840
editor opens
change each 'pick' to 'edit'
save the file and quit
$ git commit --amend -s --no-edit
$ git rebase --continue # and repeat the amend for each commit
$ git push -fAmending updates the existing PR. You DO NOT need to open a new one. |
Signed-off-by: David Chung <[email protected]>
Signed-off-by: David Chung <[email protected]>
Codecov Report@@ Coverage Diff @@
## master #371 +/- ##
==========================================
- Coverage 66.34% 63.57% -2.77%
==========================================
Files 47 52 +5
Lines 2371 2817 +446
==========================================
+ Hits 1573 1791 +218
- Misses 629 805 +176
- Partials 169 221 +52
Continue to review full report at Codecov.
|
Signed-off-by: David Chung <[email protected]>
Signed-off-by: David Chung <[email protected]>
Signed-off-by: David Chung <[email protected]>
Signed-off-by: David Chung <[email protected]>
Signed-off-by: David Chung <[email protected]>
chungers
pushed a commit
to chungers/infrakit
that referenced
this pull request
Sep 30, 2017
* Fixed swarm inquiry Signed-off-by: French Ben <[email protected]> * Fixed time format Signed-off-by: French Ben <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the following incompatible API changes to the Instance and Flavor Plugins:
New
Label()Method Requirement for Instance PluginAddition of a new
Label()method requirement on the Instance Plugin SPI. This adds a new requirement for Instance plugins to implement method for labeling / tagging a resource:Use
*types.Anyinstead of*json.RawMessage*json.RawMessagein the methods of Flavor and Instance plugin methods with*types.Any.types.Anyto represent user-defined, opaque structs.INSTANCE PLUGIN DEVELOPERS
Instead of the following boilerplate code
Use this instead: