Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Adding the ablility to have path #1749

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

ArielExperitest
Copy link

Our Docker Swarm have a unique URI that contains path(e.g. scheme://host:port/path/segment/).
So we need to add to OkHttp transports the ability to have path segment

Making OkHttp transports can have in his URL PathSegment
@bsideup
Copy link
Member

bsideup commented Dec 14, 2021

@ArielExperitest could you please add it to all transports? Also, we should also add tests for this change (eg I am not sure that addPathSegment is the right method)

@bsideup bsideup mentioned this pull request Dec 17, 2021
@bsideup
Copy link
Member

bsideup commented Feb 4, 2022

Hey @ArielExperitest,

I just submitted #1801 that adds path support to every supported transport and basic tests.

Thank you for requesting this feature! I didn't know that it is possible, actually :)

@bsideup bsideup closed this Feb 4, 2022
@ArielExperitest
Copy link
Author

@bsideup I never got the time to add the right requirement to my pull request.
Thank you to make this feature happen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants